Repository navigation
Let a sequence step show several code ranges - #628
Conversation
e2b487d to
b192a69
Compare
|
hey! @jykim256 tysm for the contribution !! sorry for the delay on this, have been working on some diffr data model improvements to fix up the diagram code snippets. i'm a bit confused by this though - "the multiple code snippets in a stop" doesn't feel very natural for a sequence diagram? are the other code snippets like context or something? and the limit of 10 feels a bit arbitrary. |
hey @sidkmenon no worries on the delay! good q. the way i think about it, an arrow in a sequence diagram is at least two places in code: where A makes the call, and where B handles it. depending on the step, you want to see the call site, the definition, or both. sometimes you only want the 3 lines that matter from each, not the whole function. so they're not really context, they're both ends of the same arrow. fair on the 10 too. i don't have a strong reason for it. happy to drop it, or cap it lower like 3 if you'd rather keep steps tight. |
b192a69 to
a136ea8
Compare
A step stands for one call, but one range often can't show it: the call reads wrong without the type it passes or the code that builds its argument. A step's source can now list up to four ranges: the call site, then ranges directly about that call. Each range is its own reference and its own code card, spaced 12px apart with the tour rail running faintly through the gaps. The sequence check refuses a range listed twice in a step, and an extra range that holds another step's code (that is the next step, not more of this one). A range longer than a call (over 12 lines) comes back as a warning. The component reference tells authors a step's source is the line its arrow leaves from, and to add a range only when that line can't be read without it. Code peek and tour cards now keep their context to the pinned lines plus each enclosing scope's first and last lines, instead of filling whole context runs that touch a scope boundary. Rewritten on current main from Jaeyoon Kim's original multi-chunk change. Co-authored-by: ketan0 <ketanjayagrawal@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: 01a0d12e-51ca-7230-9991-0ce7a73018b2
a136ea8 to
c8c2bdd
Compare
ketan0
changed the title
…olumn edge (#1192) The side panel body hides its native scrollbar and draws an overlay thumb over its right edge that takes no layout width. It shows while the body scrolls, while the pointer is over its lane, and while dragged, then fades, like Code OSS's overlay scrollbars. Tour and peek code cards now run to the column's right edge instead of stopping at a 10px gutter. Based on main; does not depend on #628. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
A sequence step stands for one call, but one range often can't show it: the call reads wrong without the type it passes or the code that builds its argument.
sourcecan list up to 4 ranges: the call site, then ranges directly about that call. Each is its own reference and its own code card, spaced 12px apart with the tour rail running through the gaps.ketan rewrote this on current main from Jae's original multi-chunk change; Jae stays the author.
🤖 Generated with Claude Code