Conversation
thesiti92
force-pushed
the
remote/10-diffr-npm-packages
branch
2 times, most recently
from
October 5, 2026 22:26
1aeb32b to
b9736dd
Compare
thesiti92
force-pushed
the
remote/10-diffr-npm-packages
branch
from
October 6, 2026 03:46
b9736dd to
0a501e8
Compare
thesiti92
changed the base branch from
remote/9-source-windows
to
remote/10-gateway-transport
October 6, 2026 13:09
thesiti92
added this pull request to stack #943
October 6, 2026 13:09
@dev.fast/diffr 0.1.11 ships the binary as optional per-platform packages, so the server finds diffr with diffrBinaryPath() instead of a bundled bin/diffr or a fetched copy. Agent-Session: 459ae7ec-7302-42c5-b473-4e315a7e4e19 Agent-Session: 96eed70a-4af6-4249-a91d-8064746610b6 Agent-Session: a5134983-fbca-42d2-ac6c-fe14cf3ce20e Agent-Session: 01a0fd55-7d25-70c3-bf87-46cdb881d91e Agent-Session: 9c8a2d13-4198-4d4b-bf1d-4de6fccd0f19 Agent-Session: 99df4638-b570-4eeb-b115-0311294ee04d Agent-Session: 2cfc4ef0-4d24-4442-8eb4-6d35cd498eeb Agent-Session: d9b59ba5-fdb1-49e5-85d8-9ad33d77e66a Agent-Session: 4d2db452-9ddb-42e0-ae76-22080016d1f8 Agent-Session: 095327a8-9eac-4f8f-9008-f88d1feb914e
Remote attach no longer fetches diffr from GitHub: `remote diffr ensure`, attach's diffr field and the installer's fetch step go. The installer omits optional dependencies, so it names @dev.fast/diffr-<target> explicitly; a host without registry access gets it through the relay. Agent-Session: 459ae7ec-7302-42c5-b473-4e315a7e4e19 Agent-Session: 96eed70a-4af6-4249-a91d-8064746610b6 Agent-Session: a5134983-fbca-42d2-ac6c-fe14cf3ce20e Agent-Session: 01a0fd55-7d25-70c3-bf87-46cdb881d91e Agent-Session: 9c8a2d13-4198-4d4b-bf1d-4de6fccd0f19 Agent-Session: 99df4638-b570-4eeb-b115-0311294ee04d Agent-Session: 2cfc4ef0-4d24-4442-8eb4-6d35cd498eeb Agent-Session: d9b59ba5-fdb1-49e5-85d8-9ad33d77e66a Agent-Session: 4d2db452-9ddb-42e0-ae76-22080016d1f8 Agent-Session: 095327a8-9eac-4f8f-9008-f88d1feb914e
pnpm deploy already installs the platform package into the runtime, so staging stops copying bin/diffr and ensure:diffr goes from packaging, run.sh and CI. Signing, the closure check and the smoke scripts use the new path. Agent-Session: 459ae7ec-7302-42c5-b473-4e315a7e4e19 Agent-Session: 96eed70a-4af6-4249-a91d-8064746610b6 Agent-Session: a5134983-fbca-42d2-ac6c-fe14cf3ce20e Agent-Session: 01a0fd55-7d25-70c3-bf87-46cdb881d91e Agent-Session: 9c8a2d13-4198-4d4b-bf1d-4de6fccd0f19 Agent-Session: 99df4638-b570-4eeb-b115-0311294ee04d Agent-Session: 2cfc4ef0-4d24-4442-8eb4-6d35cd498eeb Agent-Session: d9b59ba5-fdb1-49e5-85d8-9ad33d77e66a Agent-Session: 4d2db452-9ddb-42e0-ae76-22080016d1f8 Agent-Session: 095327a8-9eac-4f8f-9008-f88d1feb914e
The platform package is the full edition, so the command, its endpoint and journey, and the separate install under ~/.cache/diffr are no longer needed. Agent-Session: 459ae7ec-7302-42c5-b473-4e315a7e4e19 Agent-Session: 96eed70a-4af6-4249-a91d-8064746610b6 Agent-Session: a5134983-fbca-42d2-ac6c-fe14cf3ce20e Agent-Session: 01a0fd55-7d25-70c3-bf87-46cdb881d91e Agent-Session: 9c8a2d13-4198-4d4b-bf1d-4de6fccd0f19 Agent-Session: 99df4638-b570-4eeb-b115-0311294ee04d Agent-Session: 2cfc4ef0-4d24-4442-8eb4-6d35cd498eeb Agent-Session: d9b59ba5-fdb1-49e5-85d8-9ad33d77e66a Agent-Session: 4d2db452-9ddb-42e0-ae76-22080016d1f8 Agent-Session: 095327a8-9eac-4f8f-9008-f88d1feb914e
thesiti92
force-pushed
the
remote/10-diffr-npm-packages
branch
from
October 6, 2026 13:19
0a501e8 to
ca62a03
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #942. diffr now reaches each machine through npm instead of a GitHub download at attach time, and there is one diffr binary (the full edition) everywhere.
@dev.fast/diffr0.1.11 (devdotfast/diffr#88, released fromrelease/0.1.x) lists@dev.fast/diffr-{darwin-arm64,darwin-x64,linux-x64,linux-arm64,win32-x64}as optional dependencies, anddiffrBinaryPath()finds the installed one. It is the 0.1.10 code; diffr main's wire changes are not in it.diffrExecutable()isREVIEW_DIFFR_BINARY, thendiffrBinaryPath(), thendiffron PATH.ensureDiffr,whiteboard remote diffr ensure,diffrinremote attachoutput (nothing read it), the fetched copy under~/.dev/review-tools/diffr-fetch,diffr-languages.ts,POST /diffr-languages/install, the Install extra diffr languages command and its journey, andensure:diffrin packaging,run.shand CI.pnpm deploy --prodalready puts the platform package inreview-runtime/node_modules, so the runtime no longer copiesbin/diffr.sign.tsgives the binary its entitlements at the new path; the closure check,lsp-e2e.mjs,smoke-windows.mjsand the NixOS probe point there too.--omit=optional(it leaves out ~650 MB of agent binaries), so the install names@dev.fast/diffr-<target>@<version>, with the version read from the package tarball. A host without registry access gets it through Desktop's relay.package.jsonfiles, and the six packages are inminimumReleaseAgeExclude.Test plan
pnpm lint,pnpm format, frozen install.vitest: structural-diff, background-server, diffr-config, headless-host, remote-uninstall (114 pass).bundled-diffr.integration.mjs(11 pass): a relocated runtime with the real 0.1.11 packages innode_modules; override, PATH fallback and host-binary cases.runtime-bundler.test.mjs, rootscripts/**/*.test.mjs.WB_TEST_CONTAINERS=1installer suite (9 pass): a Linux container gets@dev.fast/diffr-linux-*under--omit=optional, no agent binaries, and structural diff answers; the sealed host gets diffr through the relay.diffr-linux-x640.1.11 and it runs.reviewRemoteInstaller.test.ts: 12 tests fail on this machine with and without this change (local npm environment); CI decides.node_modules.remote-installjourney (the sealed host now has diffr through the relay).