Skip to content

fix: prefer playwright headless shell for pdf rendering - #16

Merged
developer0hye merged 1 commit into
mainfrom
fix/headless-shell-priority
Mar 10, 2026
Merged

fix: prefer playwright headless shell for pdf rendering#16
developer0hye merged 1 commit into
mainfrom
fix/headless-shell-priority

Conversation

@developer0hye

@developer0hye developer0hye commented Mar 10, 2026

Copy link
Copy Markdown
Owner

What changed

  • Prefer Playwright headless shell installations before normal Chrome/Edge/Chromium when MARKNEST_BROWSER_PATH is not set
  • Add browser resolution tests for configured path precedence, headless-shell precedence, and highest-version selection
  • Update README browser discovery notes for the new runtime order

Why

  • System Chrome could surface a visible window during marknest convert
  • The headless-shell binary gives a more predictable headless path for PDF rendering

Testing

  • cargo fmt --all
  • cargo test -p marknest
  • cargo run -p marknest -- convert README.md --render-report target/headless-shell-main-report.json -o target/headless-shell-main.pdf
  • Manual GitHub URL conversions against jsvine/pdfplumber, karpathy/autoresearch, and mermaid-js/mermaid

Related: none

Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
@developer0hye
developer0hye merged commit c8fdf2f into main Mar 10, 2026
2 checks passed
@developer0hye
developer0hye deleted the fix/headless-shell-priority branch March 10, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant