fix: use gif for demo video in README - #23
Merged
Merged
Conversation
GitHub README doesn't resolve relative paths in <video> src. Use raw.githubusercontent.com URL instead. Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
GitHub strips <video> tags in README rendering. Convert demo video to GIF (720p, 10fps, 1.9MB) which GitHub renders inline as an image. Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
developer0hye
changed the title
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<video>tags in README rendering, so the demo video was invisible.mp4with animated.gif(720p, 10fps, 1.9MB) which GitHub renders inline.mp4file from the repoTest plan