fix: skip reference-style images in markdown image extraction - #5
Merged
Merged
Conversation
extract_markdown_image_destinations() searched for any `](` after `![`, causing reference-style images like `[![Badge]][ref]` to false-match with unrelated inline links further in the document. This produced spurious remote-asset advisories for serde-rs/serde (https://serde.rs) and mkdocs/mkdocs (LICENSE URL). Add find_closing_bracket() to locate the actual `]` closing the alt text, then verify `(` immediately follows before extracting the URL. Reference-style images are now correctly skipped. Related: #1 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extract_markdown_image_destinations()incorrectly matched reference-style images ([![Badge]][ref]) with unrelated inline links ([text](url)) further in the document, because it searched for any](after![without verifying bracket pairingfind_closing_bracket()to properly locate the alt-text closing], then checks that(immediately follows before extracting a URLThis fixes the spurious corpus advisories for serde-rs/serde (
https://serde.rs) and mkdocs/mkdocs (LICENSEURL).Related: #1
Test plan
does_not_extract_reference_style_images_as_remote_assetswith fixture containing both reference-style badges and inline images — verifies only inline images are extracted🤖 Generated with Claude Code