refactor: use MaybeSend/MaybeSync on registry traits#35
Open
alukach wants to merge 1 commit into
Open
Conversation
…istry This allows WASM implementations to use !Send types (like worker::Fetch and the CF Cache API) directly, eliminating the need for spawn_local + oneshot channel bridges. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BucketRegistryandCredentialRegistrytrait bounds fromSend + SynctoMaybeSend + MaybeSync+ Sendto+ MaybeSend!Sendtypes (likeworker::Fetchand the CF Cache API) directlyThis eliminates the painful
spawn_local+ oneshot channel bridge pattern that every CF Workers consumer must use when implementing these traits.Test plan
cargo testpasses (all native tests)cargo check --target wasm32-unknown-unknown -p multistore-cf-workerspasses🤖 Generated with Claude Code