Repository navigation
fix(device): say "since", not "asked", when a person took control unasked - #279
Merged
Merged
Conversation
…sked `dcd device human` labelled the start of a takeover "asked", though the agent never asked for anything. A request a person picked up stays "asked". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. (Small change: a 4-line label switch in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When a person takes control of a session in the console without being asked,
dcd device humanshowed:The agent never asked for anything, so "asked" is misleading.
Change
sincewhen a person has control and the reason is a takeover (<email> took control).asked.The API's matching session warning is fixed in devicecloud-dev/dcd#1861.
Testing
pnpm lint(no new warnings),pnpm typecheck,pnpm build.pnpm test: 514 passing. ThehumanFieldstest now covers both cases.🤖 Generated with Claude Code