Skip to content

chore(deps): bump the qs override to 6.16.1 - #285

Merged
finalerock44 merged 1 commit into
devfrom
chore/deps-qs-6-16-1
Oct 28, 2026
Merged

finalerock44 merged 1 commit into
devfrom
chore/deps-qs-6-16-1

Conversation

@finalerock44

Copy link
Copy Markdown
Contributor

GHSA-6pq8-jhm2-2vcw (moderate, published 2026-10-28) covers qs up to 6.16.0, which is exactly where the override held it, so the CI audit fails on every branch. 6.16.1 is the lowest patched version in the major; the lockfile change is qs alone (it reaches us through @modelcontextprotocol/sdk > express). Dependabot cannot bump an overridden pin, hence by hand, as for hono.

What & why

Type of change

  • fix — bug fix
  • feat — new feature
  • perf — performance improvement
  • refactor — code change that's neither a fix nor a feature
  • docs — documentation only
  • chore / ci / build / test — tooling, no user-facing change
  • Breaking change (title has ! or PR notes a BREAKING CHANGE:)

Checklist

  • PR title follows the Conventional Commits format (see comment above)
  • pnpm lint passes
  • pnpm typecheck passes
  • pnpm build passes
  • I have not bumped the version or edited CHANGELOG.md (release-please handles this)
  • I have signed the CLA (the bot will prompt on first contribution)
  • Docs / README.md / STYLE_GUIDE.md updated if behaviour or output changed

How to test

GHSA-6pq8-jhm2-2vcw (moderate, published 2026-10-28) covers qs up to
6.16.0, which is exactly where the override held it, so the CI audit
fails on every branch. 6.16.1 is the lowest patched version in the
major; the lockfile change is qs alone (it reaches us through
@modelcontextprotocol/sdk > express). Dependabot cannot bump an
overridden pin, hence by hand, as for hono.
@finalerock44 finalerock44 self-assigned this Oct 28, 2026
@claude

claude Bot commented Oct 28, 2026

Copy link
Copy Markdown

Code review

No issues found. This is a one-line bump of the qs override (qs@<6.16.1 → 6.16.1), and package.json and pnpm-lock.yaml agree on it. In the lockfile, express now resolves to qs@6.16.1, which was already present, and the orphaned qs@6.16.0 entries are removed. The change is small and obviously correct, so it did not get the full multi-agent review. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

@finalerock44
finalerock44 merged commit 2e5b87c into dev Oct 28, 2026
9 checks passed
@finalerock44
finalerock44 deleted the chore/deps-qs-6-16-1 branch October 28, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant