fix(meerkat-core): rewrite join conditions for aliased bridge tables#299
Open
sree-vardhan-reddy-D wants to merge 2 commits into
Open
fix(meerkat-core): rewrite join conditions for aliased bridge tables#299sree-vardhan-reddy-D wants to merge 2 commits into
sree-vardhan-reddy-D wants to merge 2 commits into
Conversation
sree-vardhan-reddy-D
requested review from
itsTalwar,
ujaval403,
vpbs2 and
zaidjan-devrev
as code owners
July 22, 2026 09:16
|
1 similar comment
|
shriram-devrev
approved these changes
Jul 23, 2026
sree-vardhan-reddy-D
force-pushed
the
fix/bridge-join-condition-alias
branch
from
July 23, 2026 09:28
60f4798 to
d527ddd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
link→link__1), rewrite ON-clause condition members to use the aliased table so the second linked path resolves correctly.-while sibling Child of paths work.@devrev/meerkat-core,@devrev/meerkat-node, and@devrev/meerkat-browserto0.0.135.Issue: https://app.devrev.ai/devrev/issue/SURFF-1339
Test plan
link__1.link_type_idjoins-v2suite passes (16 tests)