Repository navigation
chore(tooling): standardize on mise and prek - #140
Merged
Merged
Conversation
Pin go, golangci-lint, goreleaser and prek in mise.toml with mise.lock. Move Taskfile tasks to mise tasks, convert .pre-commit-config.yaml to prek.toml, and run the pre-commit workflow through jdx/mise-action.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters: 1
📒 Files selected for processing: 7
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
mise.toml+mise.lock(linux-x64, macos-arm64) pinning all tool versions.Taskfile.yml; tasks moved to[tasks]inmise.toml(same names)..pre-commit-config.yamltoprek.toml(viaprek util yaml-to-toml; same repos, revs, args, stages, filters). Remote golangci-lint hooks kept.pre-commit.ymlworkflow:j178/prek-actionreplaced byjdx/mise-action(SHA-pinned, same as microsandbox/runtime-sdk) +prek run --all-files.Tool versions
~> v2(latest 2.x)Task mapping
task build:climise run build:clitask build:provider:devmise run build:provider:devtask build:provider:releasemise run build:provider:release(VERSION fromgit describein shell)mise run setup,setup:dependencies,setup:hooks(prek install)Verification
prek validate-config prek.toml: valid.prek run --all-files: all hooks Passed (shellcheck/shfmt skipped, no files).mise run build:provider:dev: goreleaser snapshot + provider.yaml generated OK.build:provider:releasenot run (needs a tag/dist; logic is a direct translation).Risks
prekmanager yet (New package manager: prek renovatebot/renovate#41683), so hookrevs inprek.tomlwill not be auto-bumped until it lands; thepre-commitmanager only matches.pre-commit-config.yaml..devcontainerstill installs prek via the devcontainers-extra feature; mise is not installed there.lint.ymlandrelease.yamlunchanged (they use golangci-lint-action / goreleaser-action, not task/prek-action).