Skip to content

ci(release): upload provider.yaml with gh release upload - #31

Merged
skevetter merged 1 commit into
mainfrom
ci/release-gh-upload
Oct 19, 2026
Merged

skevetter merged 1 commit into
mainfrom
ci/release-gh-upload

Conversation

@skevetter

@skevetter skevetter commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

softprops/action-gh-release failed on its update-release call in devsy-provider-ssh v1.1.43 (Resource not accessible by integration), leaving the release as Latest without provider.yaml and failing downstream devsy provider add runs with a 404.

Replace it with gh release upload --clobber, which only uses the upload-asset API (same approach already used by devsy-provider-azure and devsy-provider-microsandbox). The tag is passed through env, not interpolated into the script.

Verified: actionlint clean; the exact gh release upload ... --clobber command succeeded against the real devsy-provider-ssh v1.1.43 release.

Summary by CodeRabbit

  • Release Management
    • Release packages now include the provider.yaml file on the release identified by its release metadata. If a file with the same name is already attached, it is replaced with the latest version.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ad0d10f1-9bdb-4f8a-96fd-34293eca4f27
📥 Commits

Reviewing files that changed from the base of the PR and between 3b26b06 and 12c13e4.

📒 Files selected for processing: 1
  • .github/workflows/release.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The release workflow replaces softprops/action-gh-release with gh release upload to upload provider.yaml using the GoReleaser metadata tag and --clobber.

Changes: Release asset upload

Layer / File(s) Summary
Release asset upload command
.github/workflows/release.yaml
The workflow uses gh release upload with the GoReleaser metadata tag, --clobber, and GH_TOKEN and TAG environment variables.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 12c13

The release workflow now uploads provider.yaml with the GitHub CLI, and the workflow already grants the write permission it needs. No actionable merge risk remains.

### Architecture Summary

Architecture risk: 🔵 Low · up to 12c13

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/release.yaml: The upload step replaces softprops/action-gh-release and its tag and file inputs with gh release upload, passing the GoReleaser metadata tag, enabling --clobber, and setting GH_TOKEN and TAG in the environment.
Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: using gh release upload to upload provider.yaml in the release workflow.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@skevetter
skevetter merged commit e8f76e0 into main Oct 19, 2026
6 checks passed
@skevetter
skevetter deleted the ci/release-gh-upload branch October 19, 2026 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant