Skip to content

refactor(workspace): rename collectProWorkspaceInfo to collectPlatformWorkspaceInfo - #1606

Merged
skevetter merged 1 commit into
mainfrom
refactor/platform-rename-troubleshoot-info
Oct 20, 2026
Merged

skevetter merged 1 commit into
mainfrom
refactor/platform-rename-troubleshoot-info

Conversation

@skevetter

@skevetter skevetter commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Rename collectProWorkspaceInfo to collectPlatformWorkspaceInfo in cmd/workspace/troubleshoot.go.
  • Replace the workspaceUID, project string params with one opts platform.FindInstanceOptions; the caller builds it from ws.UID and ws.Platform.Project.
  • Doc comment: "Devsy Pro instance" to "Devsy Platform instance". Log/error strings unchanged.

Why

Follow-up to #1603, which deferred this rename because the longer identifier pushed the signature over revive's argument-limit. Passing the existing platform.FindInstanceOptions cuts the signature to 4 params, so no //nolint is needed.

Tier

T1: internal unexported identifier, behaviour-preserving.

Validation

  • go build ./...: pass
  • GOOS=windows go vet ./cmd/workspace/...: pass
  • mise run cli:format: no changes
  • mise run cli:lint:ci: first run hit golangci-lint's 10m timeout (.golangci.yaml). Re-ran the same command with --timeout=30m: 0 issues.
  • go test ./cmd/workspace/...: pass
  • git grep collectProWorkspaceInfo: empty
  • git diff origin/main | grep nolint: empty

CodeRabbit CLI

Failed: rate limit (free OSS reviews exhausted, reset in about 12 minutes). Not retried. The GitHub CodeRabbit review still gates.

Auto-merge

Eligible: yes. 13 changed non-test lines (5 insertions, 8 deletions), 1 file.

Remaining

Other Pro tokens in cmd/workspace not measured in this PR.

Summary by CodeRabbit

  • Bug Fixes
    • Workspace troubleshooting now uses the workspace UID and project name when gathering platform information.
    • Troubleshooting details continue to be retrieved through the appropriate workspace management connection, helping ensure results correspond to the selected workspace.

@skevetter skevetter added the rename Loft/Pro rename label Oct 20, 2026
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 05d241cb-df29-4bec-bae1-e2dc45b8b5f6
📥 Commits

Reviewing files that changed from the base of the PR and between 67da7be and f6def68.

📒 Files selected for processing: 1
  • cmd/workspace/troubleshoot.go

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

📝 Walkthrough

Workspace troubleshooting now passes the workspace UID and project name through platform.FindInstanceOptions to collectPlatformWorkspaceInfo. The helper accepts that options value. Its client initialization and troubleshooting retrieval flow remain in place.

Changes: Workspace troubleshooting lookup

Layer / File(s) Summary
Pass platform lookup options
cmd/workspace/troubleshoot.go
collectPlatformWorkspaceInfo now accepts platform.FindInstanceOptions. The troubleshooting call supplies the workspace UID and project name in that value.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to f6def

The refactor preserves workspace lookup behavior and introduces no identified merge-blocking risk.

Architecture risk: 🟡 Medium · up to f6def

The change affects 1 system.

Changed systems: cmd

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — cmd (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in cmd/workspace/troubleshoot.go: The workspace troubleshooting lookup now calls collectPlatformWorkspaceInfo with a FindInstanceOptions struct containing the workspace UID and project name instead of passing those values as separate arguments to collectProWorkspaceInfo.
  • observed — Modified behavior in cmd/workspace/troubleshoot.go: collectProWorkspaceInfo was replaced by collectPlatformWorkspaceInfo, whose parameter contract accepts platform.FindInstanceOptions rather than separate workspace UID and project parameters. Client initialization and its wrapped initialization error remain unchanged.

Reliability and maintainability

  • inferred — Risk-relevant change factors for cmd: blast_radius_1; direct_dependents_1
Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains the change, rationale, scope, and validation results. It does not follow the repository template because it omits the issue reference, change-type declaration, AI assistance d… Update the description to include the required template sections and information. Add Fixes #N or none, select the applicable change type, complete the AI assistance section and attestations, document testing or explain why integration test…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the primary refactor: renaming collectProWorkspaceInfo to collectPlatformWorkspaceInfo.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the change, rationale, scope, and validation results. It does not follow the repository template because it omits the issue reference, change-type declaration, AI assistance details and attestations, testing-template section, and checklist.

Resolution

Update the description to include the required template sections and information. Add Fixes #N or none, select the applicable change type, complete the AI assistance section and attestations, document testing or explain why integration testing is not needed with existing coverage, and complete the checklist.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit f6def68
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6ad6d5a0d1357a83bd703b5d

@netlify

netlify Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit f6def68
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6ad6d5a01b6be056471f352b

@skevetter
skevetter marked this pull request as ready for review October 20, 2026 07:37
@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@mergify

mergify Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@skevetter
skevetter merged commit fda979d into main Oct 20, 2026
199 of 201 checks passed
@skevetter
skevetter deleted the refactor/platform-rename-troubleshoot-info branch October 20, 2026 07:41
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Pull request is closed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rename Loft/Pro rename size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant