Repository navigation
docs(devcontainer): use --devcontainer flag in workspace up example - #1646
Conversation
devsy workspace up does not register --devcontainer-path; only workspace build does. Verified via go run . workspace up --help, which lists --devcontainer and no --devcontainer-path.
✅ Deploy Preview for images-devsy-sh canceled.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
✅ Deploy Preview for devsydev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
|
@coderabbitai full review |
✅ Action performedFull review finished. |
Summary
workspace upexample indevcontainer-json.mdx:--devcontainer-pathis replaced with--devcontainer.Why
devsy workspace updoes not register--devcontainer-path; onlydevsy workspace builddoes. The example would fail with an unknown-flag error.devsy workspace up --helplists--devcontainerand no--devcontainer-path.Validation
npm ciandnpm run buildinsites/docs-devsy-sh: pass.npm run check-links: 0 errors.go run . workspace up --helpandgo run . workspace build --help: flag check above.CodeRabbit CLI
coderabbit review --agent --committed --base-commit c3952565completed: 0 findings, 1 file reviewed.Auto-merge
Next
Maintainer review, then ready for review if accepted.
Summary by CodeRabbit
devsy workspace upexample to use--devcontainerwhen specifying a configuration file.