[skevetter]

Summary

• desktop/src/main/watcher.ts: workspace poll runs devsy workspace list --skip-platform instead of --skip-pro.
• desktop/src/main/__tests__/watcher.test.ts: existing poll test in the refreshWorkspaces path now asserts the exact argument list.

Why

#1639 renamed devsy workspace list --skip-pro to --skip-platform. The CLI keeps --skip-pro as a hidden alias, but the desktop app still sent the old flag.

Tier

T2: desktop passes the new flag; old CLI alias still works; CLI released together with desktop bundle.

Validation

• npm ci --ignore-scripts in desktop/
• npx vitest run src/main/__tests__/watcher.test.ts src/main/__tests__/cli.test.ts: 58 passed
• npm run test (desktop): 87 files, 1098 tests passed
• npm run check (svelte-check): 0 errors
• npm run lint:check: exit 0, 3 pre-existing warnings, none in touched files
• npx biome check on the two touched files: clean
• npx tsc --noEmit -p tsconfig.json: errors only in untouched src/main/tray.ts
• git grep -n 'skip-pro' -- desktop: only desktop/e2e/fixtures/mock-devsy.cjs
• Added-line comment scan: no added comments
• mise run cli:format not run: no Go files changed

CodeRabbit CLI

coderabbit review --agent --committed --base-commit 66e21d8460f2261f36b5714ea123051f7fa6b86d: completed, 0 findings, 2 files reviewed.

Auto-merge

Eligible: yes. Non-test changed lines: 6 (5 added, 1 removed) in 1 file. Behaviour-preserving for the CLI surface; no tests removed or weakened.

Remaining

Desktop --skip-pro hits left: only desktop/e2e/fixtures/mock-devsy.cjs, which accepts both flags and is intentionally untouched.

Summary by CodeRabbit

• Bug Fixes
  • Workspace refreshes now use the updated option to skip platform-specific processing when retrieving the workspace list through the command-line fallback. The daemon-backed workspace query remains unchanged.
  • This keeps workspace listings consistent during fallback refreshes.

[netlify]

✅ Deploy Preview for devsydev canceled.

Name	Link
🔨 Latest commit	872dd59
🔍 Latest deploy log	https://app.netlify.com/projects/devsydev/deploys/6adcfec9d7bc11585dffc827

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 582229fa-456a-41a3-afb8-8361d78d9243

Commits

Reviewing files that changed from the base of the PR and between 66e21d8 and 872dd59.

Files selected for processing: 2

• desktop/src/main/__tests__/watcher.test.ts
• desktop/src/main/watcher.ts

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Walkthrough

The workspace listing CLI fallback in Watcher.pollWorkspaces now passes --skip-platform. The test checks for this argument. The daemon-backed query path is unchanged.

Changes: Workspace List Flag

Layer / File(s)	Summary
Update workspace listing fallback desktop/src/main/watcher.ts, desktop/src/main/__tests__/watcher.test.ts	The CLI fallback replaces --skip-pro with --skip-platform. The test checks that cli.run receives the updated arguments.

Priority: Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Possibly related issues

• Issue 1551 tracks the Pro-to-Platform rename and identifies the desktop watcher flag updated in this change.

Merge Risk: Minimal · up to 872dd

The workspace watcher uses the supported renamed flag, so workspace listing should continue to work across the daemon fallback path.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check		The description covers most of the template. It has a clear What and why section that leads with the problem: the CLI renamed --skip-pro to --skip-platform in #1639, and the desktop app still sent…	Fill in the Fixes # line with an issue number or none. Tick the Refactor box under Type of change. Choose one option in the AI assistance section and complete the table if AI tools were used. Complete the Testing section: tick the Deskt…

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title "refactor(desktop): pass --skip-platform in workspace watcher" matches the change. The desktop watcher now runs workspace list --skip-platform instead of --skip-pro, and the test asserts…
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "refactor(desktop): pass --skip-platform in workspace watcher" matches the change. The desktop watcher now runs workspace list --skip-platform instead of --skip-pro, and the test asserts the exact argument list. It follows Conventional Commits form and is short, specific, and free of noise. The title labels the change as a refactor, but the PR description reports that the CLI keeps --skip-pro as a hidden alias, so the old flag still works and the observable behavior is preserved, which fits the refactor label.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

Full details: Description check

Explanation

The description covers most of the template. It has a clear What and why section that leads with the problem: the CLI renamed --skip-pro to --skip-platform in #1639, and the desktop app still sent the old flag. It includes a Tier note, a detailed Validation list, a CodeRabbit CLI result, and a Remaining note. Several template sections are missing or incomplete: the Fixes # issue reference is unfilled (it should say Fixes #N, Refs #N, or none), the Type of change checkboxes are not ticked (the change is a refactor, so that box should be checked), the AI assistance section is absent (the template requires a choice between the two checkboxes), and the Testing section has no checkbox selected. The checklist items for mise run cli:lint:ci, mise run cli:test, and the CLA are not addressed, and the Testing section does not state whether an e2e test was added or why none is needed. The description also states that the change is 'Behaviour-preserving' and that it is eligible for auto-merge, which goes beyond what the template asks for.

Resolution

Fill in the Fixes # line with an issue number or none. Tick the Refactor box under Type of change. Choose one option in the AI assistance section and complete the table if AI tools were used. Complete the Testing section: tick the Desktop change box and name the Playwright e2e test that covers the change, or tick 'No integration test needed' and name the existing spec that covers the watcher poll path. Confirm the checklist items: mise run desktop:check for the desktop change, the CLA, and the docs note if needed. Replace the Auto-merge section with a note in the Notes for reviewers section, or remove it.

Finishing Touches

✨ Simplify code

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[netlify]

✅ Deploy Preview for images-devsy-sh canceled.

Name	Link
🔨 Latest commit	872dd59
🔍 Latest deploy log	https://app.netlify.com/projects/images-devsy-sh/deploys/6adcfec93f5447d3342c892a

[mergify]

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.