Repository navigation
Fix the Sonar findings of the last day's merges - #582
Merged
Merged
Conversation
JUnit does not order several @afterall methods of one class (Sonar java:S8745, the one bug failing the quality gate). Both derive their corpus from the scan seeds and do not depend on each other, so one @afterall now calls them in a fixed order. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sonar java:S2234 (compareGain called with its arguments swapped) and java:S135 (a break and a continue in one loop) in TrainingGeneration's top selection. Collections.reverseOrder states the order, and claimSlot leaves the loop a single condition; the selected symbols are unchanged. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sonar java:S107: the private Chunk constructor #574 added took 8 parameters. The arena is only ever released on close, and a slice must never release its parent's, so a slice now passes no arena instead of an ownsArena flag. Also java:S5778 in ChunkLazyDecodeTest: the column name is built outside the lambda that must throw. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sonar findings on the dictionary filter of #576 and #580: java:S1168 twice (matchBits and codeTable returned a null array), java:S125 (a test comment read as commented-out code) and java:S9358 (a conditional around two calls of one method in the interop oracle). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the one bug failing the Sonar quality gate, plus the 8 issues the analysis of
bc4a36dafound in yesterday's merges (#573, #574, #576, #580). One commit per area:java:S8745(bug, fails the gate):SeedCorpusGeneratorhad two@AfterAllmethods, and JUnit doesn't order them. One@AfterAllnow calls both in a fixed order.java:S2234,java:S135in FSSTTrainingGeneration(String min/max by UTF-8 bytes (#565), and FSST tables vortex-jni can rebuild #573):Collections.reverseOrderinstead of swapping the comparator's arguments;breakand acontinue.The selected symbols are unchanged; the Rust FSST interop tests pass.
java:S107,java:S5778inChunk(perf: decode chunk columns on first read, and DISTINCT top-N by dictionary #574):ownsArenaflag, since a slice now passes no arena;java:S1168×2,java:S125,java:S9358in the dictionary filter (perf(reader): filter dictionary columns by their values and codes in bulk #576, perf(calcite): walk only the rows a dictionary filter selects #580):Optional, and "no code table" an empty array, instead ofnull;No behavior change.
./mvnw verifypasses (9204 tests). The fuzz seed corpus is unchanged.🤖 Generated with Claude Code