Skip to content

refactor(writer): name the OnPair scan counter's method apart from its field #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dfa1 merged 1 commit into from
Oct 20, 2026
Merged

refactor(writer): name the OnPair scan counter's method apart from its field #585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions writer/src/main/java/io/github/dfa1/vortex/writer/encode/OnPairEncodingEncoder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,12 +227,12 @@ static Trie train(VarBinBytes.Rows rows) {
}
long prev = trie.longestMatch(bytes, start, end);
int pos = start + Trie.length(prev);
if (threshold.scanned(Trie.length(prev))) {
if (threshold.scan(Trie.length(prev))) {
break;
}
while (pos < end) {
long curr = trie.longestMatch(bytes, pos, end);
if (threshold.scanned(Trie.length(curr))) {
if (threshold.scan(Trie.length(curr))) {
return trie;
}
int prevLen = Trie.length(prev);
Expand Down Expand Up @@ -279,8 +279,10 @@ private static final class Threshold {
this.nextCheck = checkInterval;
}

/// Counts `n` more bytes scanned.
///
/// @return `true` once the scan budget is exhausted
boolean scanned(int n) {
boolean scan(int n) {
scanned += n;
return scanned > budget;
}
Expand Down
Loading