Repository navigation
fix(writer): admit an integer column to the dict layout as Rust's probe does - #599
Merged
Merged
Conversation
dfa1
force-pushed
the
fix/dict-admission-probe
branch
from
October 24, 2026 12:16
638cbf4 to
4943906
Compare
…be does Rust's DictStrategy gives a column a dict layout only when its probe compressor, the full cascade with IntDictScheme, turns the column's first 8192-row block into a vortex.dict. Java admitted any column with under half distinct values and at most 2,048 of them, so a column that bit-packs better (100 small distinct I64 values: 7 bits a row against a 100-value dictionary plus codes) got a dict layout vortex-jni never writes; the taxi payment_type divergence was this. A non-null primitive column now takes the same probe: the cascade with the per-chunk integer dictionary back in, over the column's first block. Nullable and string columns keep the cardinality check: Java cascades a nullable column's values under vortex.masked, without the validity cost Rust's sampled bit-packing size carries, and picks OnPair for strings where Rust's StringDictScheme wins, so the probe would diverge more there than the check does. DictAdmissionInteropIntegrationTest writes ten column shapes with vortex-jni and vortex-java and asserts both agree on the dict layout. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SwhK4W5cgj7y7s4ZPCif5x
dfa1
force-pushed
the
fix/dict-admission-probe
branch
from
October 24, 2026 12:24
4943906 to
4f9ca0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust's
DictStrategygives a column a dict layout only when its probe compressor (the full cascade,IntDictSchemeincluded) turns the first 8192-row block into avortex.dict. Java's cardinality rule admitted columns Rust bit-packs, e.g. 100 small distinct I64 values (found probing vortex-jni 0.89 output; also the known taxipayment_typedivergence).docs/compatibility.md. Java's nullable cascade runs undervortex.maskedwithout the validity cost Rust's sampled bit-packing size carries, and Java picks OnPair where Rust'sStringDictSchemewins, so the probe would diverge more there.DictAdmissionInteropIntegrationTest: eight column shapes through vortex-jni and vortex-java, both must agree on the dict layout.Full
./mvnw verifypasses locally.🤖 Generated with Claude Code
https://claude.ai/code/session_01SwhK4W5cgj7y7s4ZPCif5x