fix: anchor links broken when trailing slash is missing#270
Merged
Conversation
…ut trailing slash Relative hrefs like `../ic-interface-spec/canister-interface/#system-api-module` resolve differently depending on whether the browser URL ends with a slash: /references/resource-limits/ + ../foo/ → /references/foo/ (correct) /references/resource-limits + ../foo/ → /foo/ (wrong) The plugin now computes an absolute root-relative path by resolving the .md link against the current file's position in the docs tree. The generated href (e.g. /references/ic-interface-spec/canister-interface/#system-api-module) is not affected by the browser URL at all, so anchor links work on both the trailing-slash and non-trailing-slash forms of every page. Closes #269
lwshang
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/references/resource-limitsinstead of/references/resource-limits/)rehype-rewrite-links.mjswas emitting relative hrefs (../foo/#anchor). Browser relative URL resolution depends on whether the current URL ends with a slash, causing the wrong target on non-trailing-slash URLs/references/ic-interface-spec/canister-interface/#system-api-module) by resolving each.mdlink against the current file's position in the docs tree — these are unaffected by the browser URL formisIndexPagedistinction (index and non-index pages are handled uniformly with absolute paths).mdlinksCloses #269
Sync recommendation
hand-written