Skip to content

chore(bazel): upgrade rules_rust to 0.74.0 #11537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
basvandijk merged 7 commits into from
Sep 11, 2026
Merged

chore(bazel): upgrade rules_rust to 0.74.0 #11537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
980509a
chore(bazel): upgrade rules_rust to 0.74.0
basvandijk Sep 10, 2026
40a39f5
Merge remote-tracking branch 'origin/master' into bas/rules-rust-0.74.0
basvandijk Sep 11, 2026
cc292ad
bin/bazel-pin.sh
basvandijk Sep 11, 2026
e1a0bb9
trimming
basvandijk Sep 11, 2026
53af716
add back the doc of cc_runtime_libs
basvandijk Sep 11, 2026
323bf20
chore(bazel): drop bazel/rustix.patch, redundant since rules_rust 0.74.0
basvandijk Sep 11, 2026
cf7cf81
chore: drop the rustix worked example from fix-build-determinism
basvandijk Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .claude/skills/fix-build-determinism/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,6 @@ Gotchas:
| Dependency | Kind | Cause | Fix | Commit |
| --- | --- | --- | --- | --- |
| **askama** (`bazel/askama.patch`) | crate (derive macro) | `Path::canonicalize()` resolved the sandbox symlink to the repo's real path; the resulting relative path's `..`-count depended on the sandbox path *depth*, so the rlib changed across output-base/nest depths. | Skip `canonicalize()` so both paths stay anchored to the sandbox. | `0d9c593299` (#10167) |
| **rustix** (`bazel/rustix.patch`) | crate (`build.rs`) | The `can_compile()` probe left a `rustix_test_can_compile` artifact in `OUT_DIR`, which rules_rust captures as a cacheable output; it embeds non-deterministic compiler-internal metadata. | Delete the probe artifact after use (upstream PR 1628). | `9f0476004b` (#10353) |
| **libssh2-sys** (`bazel/libssh2-sys.patch`) | crate (`build.rs`) | `build.rs` generated a pkgconfig file containing absolute build paths. | Disable that generation. | `737666659c` (#3197) |
| **e2fsprogs / mke2fs** (`third_party/e2fsprogs_no_external_config.patch`) | `http_archive` (rules_foreign_cc) | `configure`'s `--prefix` is the per-build `$BUILD_TMPDIR`, so the compiled-in `mke2fs.conf` path (`ROOT_SYSCONFDIR`) landed in the binary's `.rodata`. | Empty `config_fn` (use the built-in default profile) + trim the unused, also-non-reproducible extra tools from the install tree. | `cf7fe5147b` |

Expand Down
Loading
Loading