Skip to content

Fix ruff pyproject.toml deprecation and lint warnings - #399

Merged
dfm merged 3 commits into
mainfrom
copilot/fix-deprecated-linter-settings
Sep 23, 2026
Merged

dfm merged 3 commits into
mainfrom
copilot/fix-deprecated-linter-settings

Conversation

Copilot AI commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

pre-commit's ruff hook warned that top-level linter settings (select, ignore, isort) are deprecated in favor of the lint section, and flagged PLR0917 (too many positional arguments) on _get_stellar_spectrum.

Config migration

  • Moved select/ignore from [tool.ruff] to [tool.ruff.lint]
  • Moved isort settings from [tool.ruff.isort] to [tool.ruff.lint.isort]

PLR0917 suppression

  • Rather than adding a repo-wide ignore for PLR0917, suppressed it locally with # noqa: PLR0917 on the _get_stellar_spectrum definition line, since this rule shouldn't be silenced globally for a single method's signature:
def _get_stellar_spectrum(  # noqa: PLR0917
    self,
    mact,
    logt,
    lbol,
    logg,
    phase,
    comp,
    mdot=0,
    weight=1,
    zmet=None,
    peraa=True,
):
    ...

Copilot AI and others added 2 commits September 23, 2026 05:34
Co-authored-by: dfm <350282+dfm@users.noreply.github.com>
Co-authored-by: dfm <350282+dfm@users.noreply.github.com>
Co-authored-by: dfm <350282+dfm@users.noreply.github.com>
@dfm
dfm merged commit 5ac2c21 into main Sep 23, 2026
4 of 5 checks passed
Copilot stopped work on behalf of dfm due to an error September 23, 2026 05:41
Copilot AI requested a review from dfm September 23, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants