Skip to content

perf(query): pre-size slices in expansion helpers #9722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shaunpatterson wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −6
Open

perf(query): pre-size slices in expansion helpers #9722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions query/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1993,7 +1993,13 @@ func (sg *SubGraph) appendDummyValues() {
}

func getPredsFromVals(vl []*pb.ValueList) []string {
preds := make([]string, 0)
// Estimate by summing all inner ValueList lengths; a slight overcount when some
// values are empty is fine — it avoids the grow-and-copy of an unsized append.
n := 0
for _, l := range vl {
n += len(l.Values)
}
preds := make([]string, 0, n)
for _, l := range vl {
for _, v := range l.Values {
if len(v.Val) > 0 {
Expand Down Expand Up @@ -2070,12 +2076,12 @@ func expandSubgraph(ctx context.Context, sg *SubGraph) ([]*SubGraph, error) {
preds = getPredicatesFromTypes(namespace, typeNames)
// restrict preds to allowed preds if ACL is turned on.
if sg.Params.AllowedPreds != nil {
// Take intersection of both the predicate lists
intersectPreds := make([]string, 0)
hashMap := make(map[string]bool)
// Take intersection of both the predicate lists.
hashMap := make(map[string]bool, len(sg.Params.AllowedPreds))
for _, allowedPred := range sg.Params.AllowedPreds {
hashMap[allowedPred] = true
}
intersectPreds := make([]string, 0, len(preds))
for _, pred := range preds {
if _, found := hashMap[pred]; found {
intersectPreds = append(intersectPreds, pred)
Expand Down Expand Up @@ -2796,7 +2802,8 @@ func getNodeTypes(ctx context.Context, sg *SubGraph) ([]string, error) {

// getPredicatesFromTypes returns the list of preds contained in the given types.
func getPredicatesFromTypes(namespace uint64, typeNames []string) []string {
var preds []string
// Estimate at 4 fields per type — typical for graph schemas.
preds := make([]string, 0, len(typeNames)*4)

for _, typeName := range typeNames {
typeDef, ok := schema.State().GetType(x.NamespaceAttr(namespace, typeName))
Expand All @@ -2819,7 +2826,7 @@ func filterUidPredicates(ctx context.Context, preds []string) ([]string, error)
return nil, err
}

filteredPreds := make([]string, 0)
filteredPreds := make([]string, 0, len(schs))
for _, sch := range schs {
if sch.GetType() != "uid" {
continue
Expand Down
Loading