Fix --mute flag being ignored - #713
Merged
Merged
Conversation
cmd/skyeye/main.go set conf.Configuration.Mute from the flag, but app.go never passed it into srs.ClientConfiguration, so the SRS client always transmitted regardless of the flag. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Split off from #712, which found this while working in the same area.
cmd/skyeye/main.gosetsconf.Configuration.Mutefrom the--muteflag, butinternal/application/app.gonever passed it intosrs.ClientConfigurationwhen constructing the SRS client. The field already existed onClientConfiguration- it just wasn't wired up, so the flag was a silent no-op.Fix
Pass
config.Mutethrough inNewApplication.Testing
🤖 Generated with Claude Code