Upgrade golangci-lint to v2.12.2 - #718
Merged
Merged
Conversation
Bump the golangci-lint tool dependency and update go.sum accordingly. Also disable goconst for test files and the aircraft encyclopedia data table, and suppress a coincidental string overlap in locations, since these are semantically distinct duplicates rather than real repetition. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dharmab
enabled auto-merge (squash)
July 26, 2026 16:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
golangci-linttool dependency (managed viago.modtooldirective) from v2.11.3 to v2.12.2, updatinggo.sumand transitive deps viago mod tidy.goconstfor_test.gofiles, since tests legitimately reuse similar strings across cases.goconstforpkg/encyclopedia/aircraft.go: designations coincidentally repeat across semantically distinct fields (e.g. a family'sPlatformDesignationmatching a specific variant's ownACMIShortName/TypeDesignation) and across unrelated struct entries. Extracting shared constants here would create false coupling between unrelated facts.goconsthit inpkg/locations/location.go(bullseyereserved name overlaps with an unrelated word-alias list inpkg/parser).Test plan
make lintpasses with 0 issuesgo mod tidyproduces no further diff