Run tests with -race by default - #719
Merged
Merged
Conversation
Data races in concurrent code are otherwise easy to miss until they cause flaky failures in production. TEST_FLAGS still overrides the default for cases like debugging with -parallel=1. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dharmab
enabled auto-merge (squash)
July 26, 2026 17:20
dharmab
disabled auto-merge
July 26, 2026 17:22
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dharmab
force-pushed
the
enable-race-detector-in-tests
branch
from
July 26, 2026 17:24
2baba4e to
44f41c9
Compare
dharmab
enabled auto-merge (rebase)
July 26, 2026 17:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make testnow runs with-raceby default viaTEST_FLAGS ?= -race, catching data races in CITEST_FLAGSstill overrides the default for cases likeTEST_FLAGS="-race -parallel=1" make testTest plan
make test(full suite, 1154 tests) passes with-race, no data races detected🤖 Generated with Claude Code