ci: remove redundant concurrency block from issue-labeler - #58
Conversation
…e workflow validation error
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe issue-labeler workflow is simplified by removing the redundant job-level condition and concurrency block, leaving the triage job to proceed with its existing steps while eliminating the configuration that caused GitHub Actions validation errors. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
@sourcery-ai review |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".github/workflows/issue-labeler.yml" line_range="24-26" />
<code_context>
name: triage
runs-on: ubuntu-latest
- if: github.event.issue != null
- concurrency:
- group: issue-metadata-${{ github.event.issue.number }}
- cancel-in-progress: true
steps:
- name: Checkout repository
</code_context>
<issue_to_address>
**issue (bug_risk):** Removing the per-issue concurrency group allows multiple `edited` runs for the same issue to execute concurrently. Each run computes `finalLabels` from its event's potentially stale `issue.labels` snapshot and then calls `setLabels`, so an older run can finish last and overwrite labels calculated from a newer edit.
**Triggers:** When an issue is edited again before the previous labeling run completes.
**Suggested fix:** Retain a valid per-issue concurrency group, or otherwise serialize label updates for the same issue.
</issue_to_address>Sourcery assessment
Needs a human reviewer. 1 finding to address first, and removing concurrency can allow overlapping runs to race while updating issue labels, and removing the event guard can run the job for events without an issue. Reverting restores the previous behavior, but any incorrect labels or metadata written before the revert would need to be repaired or the job rerun.
Blocking findings: .github/workflows/issue-labeler.yml:26
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Remove redundant concurrency block from issue-labeler to permanently eliminate workflow file validation errors on GitHub Actions.
Summary by Sourcery
Improve issue and pull request labeling workflows by making concurrency reliable, using current issue state, and removing automatic AI review triggers.
Bug Fixes:
Enhancements: