feat: [DHIS2-21875] Unify overflow menu between View Event page and Stages and Events widget - #4657
Open
henrikmv wants to merge 77 commits into
Conversation
henrikmv
changed the base branch from
master
to
hv/feat/DHIS2-21655_uncomplete-event-view-mode
July 22, 2026 12:32
henrikmv
marked this pull request as draft
July 22, 2026 12:32
…vent-view-mode' into hv/feat/DHIS2-21875_unify-overflow-menus-event
|
🚀 Deployed on https://deploy-preview-4657.capture.netlify.dhis2.org |
…vent-view-mode' into hv/feat/DHIS2-21875_unify-overflow-menus-event
…/feat/DHIS2-21875_unify-overflow-menus-event
…vent-view-mode' into hv/feat/DHIS2-21875_unify-overflow-menus-event
…/feat/DHIS2-21875_unify-overflow-menus-event
…vent-view-mode' into hv/feat/DHIS2-21875_unify-overflow-menus-event
…vent-view-mode' into hv/feat/DHIS2-21875_unify-overflow-menus-event
…/feat/DHIS2-21875_unify-overflow-menus-event
…/feat/DHIS2-21875_unify-overflow-menus-event
…vent-view-mode' into hv/feat/DHIS2-21875_unify-overflow-menus-event
…hv/feat/DHIS2-21875_unify-overflow-menus-event
…hv/feat/DHIS2-21875_unify-overflow-menus-event
…with isEventBlockedByCompletion
…hv/feat/DHIS2-21875_unify-overflow-menus-event
…nd update overflow menu visibility
…hv/feat/DHIS2-21875_unify-overflow-menus-event
…hv/feat/DHIS2-21875_unify-overflow-menus-event
|
henrikmv
marked this pull request as ready for review
August 28, 2026 12:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



DHIS2-21875
Verification matrix by event status
Baseline: user has
canEditProgramStage. Without it, no mutation actions appear at all (overflow menu section hidden).blockEntryForm=false)F_UNCOMPLETE_EVENTAND (not expired OR hasF_EDIT_EXPIRED)blockEntryForm=true)F_UNCOMPLETE_EVENTAND (not expired OR hasF_EDIT_EXPIRED)occurredAt²occurredAt²Additonal information
¹ Expiry rules
"Not expired" means the event's relevant date is inside the program's editing window:
occurredAtfor ACTIVE / COMPLETEDscheduledAtfor SCHEDULE / OVERDUE / SKIPPEDF_EDIT_EXPIREDbypasses expiry checks. However, it does not bypass other permission requirements. For example, Uncomplete still requiresF_UNCOMPLETE_EVENT.² SCHEDULE / OVERDUE edit exception
For SCHEDULE and OVERDUE, form editing checks expiry against the date currently entered in the form rather than the server-side date.
This means a user without
F_EDIT_EXPIREDcan still save the event by selecting a valid date inside the editing window.³ Skip / Delete on OVERDUE
Skip and Delete continue to check the server-side
scheduledAt.If
scheduledAtis outside the editing window, both actions remain disabled unless the user hasF_EDIT_EXPIRED.Completed events with
blockEntryForm=trueWhen an event is COMPLETED and
blockEntryForm=true, the form is read-only. To edit the event, you have to Uncomplete — requiresF_UNCOMPLETE_EVENT.If the event is expired, Uncomplete also requires
F_EDIT_EXPIRED.Overflow menu visibility