fix: handle incomplete regular expressions [DHIS2-19573]#1740
Open
fix: handle incomplete regular expressions [DHIS2-19573]#1740
Conversation
|
Contributor
|
🚀 Deployed on https://pr-1740--dhis2-ui.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-19573
Description
The transfer filter uses regular expressions for filtering. This is honestly bit weird, but there might be a reason for that as the token-based filter accepts regular expressions (see thread here: https://dhis2.slack.com/archives/C0BP0RABF/p1761812319940729)
While we still may want to update this logic to not use regular expressions, the update here at least fixes things so that invalid regular expressions return all options (e.g. they are treated as there is no filter). This is better than the current error, which will result in app crash.
Known issues
Checklist
We could add this to the documentation if we think it's something we definitely want to keep? I don't think there's a need for highlighting this in a storybook demo.