fix(chart): drop duplicate app.kubernetes.io/name key from ipman.labels - #32
Merged
plan9better merged 1 commit intoSep 2, 2026
Merged
Conversation
ipman.labels already includes ipman.selectorLabels above, which unconditionally sets app.kubernetes.io/name. The `if .Chart.AppVersion` block then set the same key again, so every resource using this helper (deployment.yaml's metadata.labels and spec.template.metadata.labels) ends up with the key defined twice in one YAML mapping. Plain `helm install`/kubectl tolerate this silently (lenient YAML->JSON decoding, last duplicate wins), but installing via Flux's helm-controller fails outright, since its post-render step uses a stricter decoder: error while running post render on files: ... mapping key "app.kubernetes.io/name" already defined Confirmed present, unconditionally, in every published chart version 0.1.10-0.1.18. Reproduced and fixed while GitOps-ifying a deployment with Flux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ipman.labelsalready includesipman.selectorLabelsabove, whichunconditionally sets
app.kubernetes.io/name. Theif .Chart.AppVersionblock then sets the same key again, so every resource using this helper
(deployment.yaml's
metadata.labelsandspec.template.metadata.labels)ends up with the key defined twice in one YAML mapping.
Plain
helm install/kubectltolerate this silently (lenientYAML->JSON decoding, last duplicate wins), but installing via Flux's
helm-controller fails outright, since its post-render step uses a
stricter decoder: