fix(xfrminion): use netlink directly for bridge fdb, not the bridge binary - #34
Open
m4ci3k2 wants to merge 1 commit into
Open
fix(xfrminion): use netlink directly for bridge fdb, not the bridge binary#34m4ci3k2 wants to merge 1 commit into
m4ci3k2 wants to merge 1 commit into
Conversation
…inary Mirrors cmd/vxlandlord's fix for the same issue: the ko-built image has no bridge/iproute2 binary, so shelling out to it always fails with "exec: \"bridge\": executable file not found in $PATH". Replaces both the add and delete paths (and the delete path's extra `bridge fdb show | grep | xargs bridge fdb del` cleanup pipeline) with equivalent netlink calls (NeighAppend/NeighDel/NeighList). Verified: go build/vet/gofmt clean, and confirmed at runtime in a live cluster - the xfrm-pod's restctl calls to add/delete FDB entries now succeed instead of failing on a missing binary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors cmd/vxlandlord's fix for the same issue: the ko-built image has
no bridge/iproute2 binary, so shelling out to it always fails with
"exec: "bridge": executable file not found in $PATH". Replaces both
the add and delete paths (and the delete path's extra
bridge fdb show | grep | xargs bridge fdb delcleanup pipeline) with equivalentnetlink calls (NeighAppend/NeighDel/NeighList).
Verified: go build/vet/gofmt clean, and confirmed at runtime in a live
cluster - the xfrm-pod's restctl calls to add/delete FDB entries now
succeed instead of failing on a missing binary.