Make hidden geometry sampling independent of scene shape ordering - #13
Open
matla91 wants to merge 1 commit into
Open
Make hidden geometry sampling independent of scene shape ordering#13matla91 wants to merge 1 commit into
matla91 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hidden-geometry sampling distribution is currently built in the order returned by
scene.shapes(). The sampled distribution index is then used directly withscene.shapes_dr(). If the shape order changes, the same HGS sample can therefore select a different physical shape.This change sorts the HGS categories by
shape.id()when all scene shapes have unique, non-empty IDs. It stores the corresponding original shape indices and maps the sampled category back to the correct index before gathering fromscene.shapes_dr(). Scenes without unique, non-empty IDs keep the previous behavior.Regression test
I added a test that builds the same scene twice, with the two hidden shapes declared in opposite orders, and evaluates the same HGS sample in both scenes.
On the current
mainbranch:With this patch:
The sampling PDF is unchanged.
The regression test passes with
llvm_ad_rgbandcuda_ad_rgb. I also ran it in 10 fresh processes on each backend; all runs passed.pyteststill reports the existing failure intests/integration/test_nlos.py, where the test callsprepare_transient(). That method is not present on the currentTransientNLOSPath, and I reproduced the same failure onmainbefore making this change.