Add configurable maximum depth for hidden geometry sampling - #14
Open
matla91 wants to merge 1 commit into
Open
Conversation
matla91
marked this pull request as ready for review
August 20, 2026 09:40
Author
|
The implementation and integration tests are now complete. Validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a configurable maximum depth for Hidden Geometry Sampling (HGS) in
TransientNLOSPath.HGS can significantly improve sampling efficiency in transient NLOS rendering by generating connections to hidden geometry. However, applying HGS recursively at every path depth can lead to high-variance contributions in some scenes, especially when later path vertices create difficult sampling configurations. In these cases, limiting HGS to early path vertices can provide a useful trade-off between sampling efficiency and variance control.
The new parameter:
nlos_hidden_geometry_sampling_max_depthallows users to control how far HGS is applied along a path while keeping the existing behavior unchanged by default.
Behavior
-1(default): preserves the previous unlimited HGS behavior.N > 0: enables HGS only for path vertices with depth< N.1applies HGS only at depth0.0or< -1) raise a runtime configuration error.When the depth limit disables HGS, the BSDF method probability is restored to
1.0, since BSDF sampling becomes the only available sampling strategy at that depth.Tests
Added integration tests covering:
All added tests pass.