fix(release): install both macOS CPU variants so Intel builds get node-pty - #3414
Open
mvanhorn wants to merge 1 commit into
Open
fix(release): install both macOS CPU variants so Intel builds get node-pty#3414mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
Contributor
|
@mvanhorn is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
The four red Vercel checks here aren't from this change — they're all returning a Flagging it so it doesn't read as a broken PR. Happy to rebase or do anything else that helps, but I can't clear those from my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm install --frozen-lockfile, which resolves CPU-specific optional deps (notablynode-pty) for the runner's own architecture only. The x64 artifact built on an arm64 runner therefore shipped without a usable Intelnode-pty, and the terminal failed on Intel Macs.Why
Issue
Scope
.github/workflows/release-macos-aarch64.yml: split the singleInstall dependenciesstep into a macOS step that runspnpm install --frozen-lockfile --cpu=arm64 --cpu=x64and a Linux/Windows step that keeps the existingpnpm install --frozen-lockfile, selected bymatrix.os_type.apps/desktop/electron/electron-builder-config.test.mjs: new testinstalls both macOS CPU variants for Electron releases, which parses the release workflow and asserts the macOS matrix covers bothelectron-macos-arm64andelectron-macos-x64and that the macOS install step requests both CPUs.Out of scope
node-ptyitself, its version, or how the app loads it.Testing
Ran the Electron distribution config suite locally, which now includes the new workflow assertion.
Ran
node --test electron/electron-builder-config.test.mjs(fromapps/desktop)Result
installs both macOS CPU variants for Electron releases.CI status
Manual verification
node --test electron/electron-builder-config.test.mjsfromapps/desktop; the new case passes.pnpm install --frozen-lockfile) and re-run; the new test fails, showing it actually pins the behavior rather than passing vacuously.--cpu=arm64and--cpu=x64, and that the x64 artifact contains an Intelnode-ptybinary.Evidence
Risk
--cputarget is additive: arm64 resolution is unchanged, x64 binaries are added alongside.Rollback
Install dependenciesstep returns the previous behavior exactly, and dropping the test removes the assertion. No state, cache, or published artifact needs cleanup.