test(fake-adapter): rename re-kill test to match its assertion - #373
Merged
Conversation
Deploying mouseterm with
|
| Latest commit: |
4299a8c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f9f414bc.mouseterm.pages.dev |
| Branch Preview URL: | https://test-fake-adapter-rekill-nam.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfaced by the nightly code-quality sweep.
The test named
'killing already-killed terminals does not double-fire handlers'assertsexpect(exitEvents).toHaveLength(2)— i.e. the secondkillPtydoes fire exit again — and its own inline comment confirms "Both calls fire exit (killPty doesn't guard against re-kill)". The name states the opposite of the behavior it pins, so anyone scanning test names would believe re-kill is guarded when it isn't.Renames it to
're-killing a terminal fires exit again (no re-kill guard)'to match the asserted behavior. No code or assertion change; the test still passes (31/31 in the file).