Crashed worker to update job itself (and make the UI clearer on status)#602
Open
dale-wahl wants to merge 8 commits into
Open
Crashed worker to update job itself (and make the UI clearer on status)#602dale-wahl wants to merge 8 commits into
dale-wahl wants to merge 8 commits into
Conversation
not positive what we should do with re-occuring jobs; currently they would NOT retry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accidental journey figuring out what was going on with 20 day old jobs stuck in "Active Workers" on control panel.
Possible future improvement (but would require a db update): heartbeat. Would help with jobs that are legit stuck or silently crash. Maybe a ping from active workers every minute or so. Improve on the "is maybe crashed heuristic".