Make Rapier optional and support Rapier f64 - #8
Open
Jondolf wants to merge 1 commit into
Open
Conversation
sebcrozet
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Slosh only supports
rapier2d/rapier3dand notrapier2d-f64/rapier3d-f64. While supporting double-precision for the actual MPM simulation might be tricky or undesirable, it would still be good to be able to support coupling the simulation with Rapier for applications that do use f64 elsewhere.There's also a TODO to make Rapier optional, so I did that in this PR as well, with optional, mutually exclusive
rapier-f32andrapier-f64features. I'm happy to make any further changes here if needed.