Replace Django CI with Sanic CI and update Docker configuration#7
Merged
Conversation
…Python 3.10-3.13) and a tag-triggered GHCR Docker build, add a Dockerfile that injects the server password at run time, and re-encode requirements.txt from UTF-16 to UTF-8.
diorwave
force-pushed
the
ci/fix-stack-and-docker
branch
from
9c7b2f2 to
01635ce
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c7b2f27c7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds Docker support and sets up modern CI/CD workflows for the project. It introduces a Dockerfile and entrypoint script for containerization, configures GitHub Actions for Python testing and Docker image publishing, and cleans up legacy workflow files. The changes make the project easier to build, test, and deploy in a standardized and automated way.
Docker support and containerization:
Dockerfileto build a minimal, production-ready Python 3.13 container image for the app, with best practices like unprivileged user, environment variable configuration, and exclusion of secrets from the image.docker-entrypoint.shscript to securely launch the app, requiring thePASSWORDenvironment variable at runtime and allowing host/port overrides..dockerignorefile to keep build context small and secure by excluding unnecessary files, secrets, and development artifacts from Docker images.CI/CD workflow improvements:
.github/workflows/ci.ymlfor Python test automation on pushes and PRs tomain, testing across Python 3.9–3.13 with pip caching for efficiency..github/workflows/docker-publish.ymlto automatically build and publish Docker images to GitHub Container Registry (GHCR) on version tags, with semantic versioning and caching..github/workflows/django.ymlworkflow, which targeted older Python versions and a Django-specific test command no longer relevant to the project.