feat: make the Plan/Act toggle shortcut configurable#124
Open
youdie006 wants to merge 1 commit into
Open
Conversation
The Plan/Act toggle was hardcoded to Meta/Ctrl+Shift+a, which collides with VSCode's Cmd/Ctrl+Shift+A "Agents" command. Change the default to the Alt+Shift+a binding the maintainer endorsed, and add an opt-in dirac.planActToggleShortcut setting that overrides it (empty = default), so the collision is fixed for everyone without forcing a broad customization surface. The setting is injected into the webview and resolved by a pure resolveTogglePlanActKeys helper; changing it re-renders the webview live. Closes dirac-run#100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Plan/Act toggle shortcut was hardcoded to
Meta/Ctrl+Shift+a, which collides with VSCode's newCmd/Ctrl+Shift+A"Agents" command (#100).Fix
Alt+Shift+a— the binding the maintainer endorsed in the issue thread — fixing the collision for everyone with zero new surface.dirac.planActToggleShortcutsetting that overrides the default (empty = unchanged behavior), addressing the "conflicts aren't zero" concern without forcing a broad keybinding-customization pipeline. The setting is injected into the webview (window.__DIRAC_CONFIG__) and resolved by a pureresolveTogglePlanActKeyshelper; changing it re-renders the webview live.This deliberately avoids the gRPC
ExtensionState/state-keyspath (which would auto-regenerate the state proto). Added unit tests for the resolver.Closes #100