Repository navigation
Conversation
catchup hard-reset every directory under plugins/ with a .git. A plugin bind-mounted with `dv new --plugin-local` is the host's checkout, so `git reset --hard` and `git clean -df` inside the container deleted uncommitted work on the host. The prompt listed it like any cloned plugin, so nothing warned that the reset reached outside the container. Reproduce on main: `dv new --plugin-local ~/work/my-plugin`, edit a file in ~/work/my-plugin without committing, `dv catchup -y`. The edit is gone from the host. catchup now inspects the container's mounts and leaves any plugin whose directory is a mount destination out of the reset, listing it in the prompt (and in the -y log) as left alone. Everything it can still reset lives inside the container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
catchup hard-reset every directory under plugins/ with a .git. A plugin bind-mounted with
dv new --plugin-localis the host's checkout, sogit reset --hardandgit clean -dfinside the container deleted uncommitted work on the host. The prompt listed it like any cloned plugin, so nothing warned that the reset reached outside the container.Reproduce on main:
dv new --plugin-local ~/work/my-plugin, edit a file in ~/work/my-plugin without committing,dv catchup -y. The edit is gone from the host.catchup now inspects the container's mounts and leaves any plugin whose directory is a mount destination out of the reset, listing it in the prompt (and in the -y log) as left alone. Everything it can still reset lives inside the container.