Repository navigation
Fix/deploy find server by port - #476
Merged
Merged
Conversation
On macOS the Homebrew interpreter shows up in ps as .../MacOS/Python, so pgrep -f 'python -m dw\.serve' finds nothing and a deploy starts a second server on a port that's taken. Match what listens on DW_PORT instead (lsof), falling back to the old pgrep where lsof is missing. Same result on lem, where one server runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dc05ab4 made every check ask what listens on DW_PORT. dw.serve imports torch for seconds before it binds, so the startup loop saw an empty port and reported 'exited during startup' on every deploy. Keep the port for choosing what to stop, wait on the pids actually signalled (uvicorn closes its socket early in a graceful shutdown), and judge startup by the process (pgrep -i, so Homebrew's .../MacOS/Python matches too). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.