Repository navigation
Roadmap: complete remaining performance, architecture and ecosystem items - #13
Merged
Merged
Conversation
- lazy KDBX4 attachments, mmap input and direct attachment streaming - format/cipher/KDF registries, DatabaseSerializer and CMake components - stable C ABI, incremental backups and extra CSV layouts - TOTP/history helpers, richer errors and CLI flags - OSS-Fuzz recipe, WASM demo, vcpkg/Homebrew, signing and CI updates
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+143
to
+155
| switch (way) { | ||
| case std::ios_base::beg: | ||
| base = 0; | ||
| break; | ||
| case std::ios_base::cur: | ||
| base = gptr() - eback(); | ||
| break; | ||
| case std::ios_base::end: | ||
| base = end_ - begin_; | ||
| break; | ||
| default: | ||
| return std::streampos(std::streamoff(-1)); | ||
| } |
| const int lo = hex(value[i + 2]); | ||
| if (hi >= 0 && lo >= 0) { | ||
| decoded.push_back(static_cast<char>((hi << 4) | lo)); | ||
| i += 2; |
Binary methods moved out of line but the class lacked LIBKEEPASS_API, so MSVC tests failed to link against the DLL. The Windows lint job now downloads run-clang-tidy.py instead of assuming LLVM ships it.
Use scoped locks, concatenated nested namespaces, guarded C ABI typedefs, braced streampos returns and non-empty exception handling. Also make the optional-access tests explicit for the new checker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the remaining open, repo-local items from
ROADMAP.md. The onlyexternal follow-up left is the actual
google/oss-fuzzsubmission PR; theproject recipe is ready in
oss-fuzz/.Performance / streaming
binaries;
Binary::data()materializes on demand andBinary::WriteTo()streams during export.
KeePass::Open(path)usesmmap/CreateFileMappingthroughdetail::MappedFile, with anifstreamfallback.Architecture / modularity
FormatCodec/FormatCodecRegistry+DatabaseSerializerabstraction;
KeePassno longer has a formatswitch.CipherRegistryandKdfRegistryfor block ciphers and KDFs.cipher.hhno longer includes OpenSSL,keepass.hhno longer pullskdbx.hh).LIBKEEPASS_COMPONENT_KDB/_KDBX) andcomponent-aware
find_package(... COMPONENTS ...)metadata/targets.APIs / usability
libkeepass-cwith opaque handles, open/save, JSON/CSV,lookup/editing and thread-local errors.
Database::DeltaSince()/DatabaseDelta::ToJson()for incremental backups.CsvFormat::kCsvWithCustomFieldsandkCsvKeePass2.TotpConfig,Totp,Entry::totp()), history trimming,kpx otp --codeandkpx purge --keep.ErrorCategory,UnsupportedFeatureError,ResourceLimitErrorand parser offsets.Ecosystem / infrastructure
setup-conancache modes replace per-workflow cache steps; Windowsclang-tidy job.
Validation
ctest --test-dir build --output-on-failure: 21/21 passedconan create . --build=missing: package +test_packagepassed-DLIBKEEPASS_COMPONENT_KDBX=OFF): passedlibkeepass-cinstalledclang-format --dry-run --Werroron changed C++ files: clean