Skip to content

Hide headshot in rendered PDF#12

Merged
dlaz merged 2 commits intomainfrom
copilot/hide-headshot-in-pdf
Apr 25, 2026
Merged

Hide headshot in rendered PDF#12
dlaz merged 2 commits intomainfrom
copilot/hide-headshot-in-pdf

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 25, 2026

  • Add img#me to the @media print hide list in styles.css
  • Also hide headshot via page.evaluate() in build.js (PDF is generated with screen media type, so the print CSS was never applied)

@dlaz dlaz marked this pull request as ready for review April 25, 2026 16:28
@github-actions
Copy link
Copy Markdown

📸 Screenshot Preview

HTML (screen)

HTML Preview

PDF (page 1)

PDF Page 1

PDF (page 2)

PDF Page 2

Generated by run #24935347286

@dlaz
Copy link
Copy Markdown
Owner

dlaz commented Apr 25, 2026

@copilot the rendered screenshot in #12 (comment) shows the headshot is still visible

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 25, 2026

@copilot the rendered screenshot in #12 (comment) shows the headshot is still visible

The root cause was that build.js generates the PDF using Puppeteer with screen media type, so @media print CSS was never applied — the headshot was only hidden there. Fixed in commit 30c0fc8 by also hiding #me directly in the page.evaluate() call alongside the other .no-pdf elements.

Copilot AI requested a review from dlaz April 25, 2026 16:33
Copilot finished work on behalf of dlaz April 25, 2026 16:33
@github-actions
Copy link
Copy Markdown

📸 Screenshot Preview

HTML (screen)

HTML Preview

PDF (page 1)

PDF Page 1

PDF (page 2)

PDF Page 2

Generated by run #24935453908

@dlaz dlaz merged commit c1bf431 into main Apr 25, 2026
1 check passed
@dlaz dlaz deleted the copilot/hide-headshot-in-pdf branch April 25, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants