Fix ReDoS in HtmlParser URL evaluation#134
Conversation
Replace unbounded repetitions `*` with length boundaries `{0,2000}`
and `{0,100}` in `URL_VALID_PATH` to prevent catastrophic backtracking
(ReDoS) when parsing complex text blocks containing overlapping characters.
Co-authored-by: dlukt <201112286+dlukt@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixes a bug where writing or displaying a status containing a complex URL structure would cause the app to hang/crash due to a catastrophic backtracking ReDoS vulnerability in
com.twitter.twittertext.Regex.By applying safe repetition length boundaries (
{0,2000}and{0,100}) to theURL_VALID_PATHregex component instead of using unbounded*repetitions, the parser can efficiently evaluate and drop invalid links without exponential backtracking.PR created automatically by Jules for task 16219277335071236597 started by @dlukt