fix(config): apply config flags to --services/--volumes/--networks/--models/--hash - #13979
Open
glours wants to merge 1 commit into
Open
fix(config): apply config flags to --services/--volumes/--networks/--models/--hash#13979glours wants to merge 1 commit into
glours wants to merge 1 commit into
Conversation
…models/--hash The runServices, runVolumes, runNetworks, runModels and runHash paths called ProjectOptions.ToProject directly, bypassing the configOptions wrapper that applies --no-consistency, --no-interpolate, --no-normalize, --no-path-resolution, --profile filtering and env_file discarding. Restore the variadic wrapper (mirroring configOptions.ToModel) and route the five call sites through it. Regression introduced by b80bb05 (LoadProject API migration). Fixes docker#13974 Signed-off-by: Guillaume Lours <glours@users.noreply.github.com>
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The fix is correct and well-scoped. The new toProject variadic wrapper properly threads the configOptions flags (--no-consistency, --no-interpolate, --no-normalize, --no-path-resolution, profile filtering, env_file discarding) through to all five affected subcommand paths (runServices, runVolumes, runNetworks, runModels, runHash). The approach mirrors the existing configOptions.ToModel pattern, is consistent with the surrounding code, and the regression is fully covered by the new e2e test.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
The runServices, runVolumes, runNetworks, runModels and runHash paths called ProjectOptions.ToProject directly, bypassing the configOptions wrapper that applies --no-consistency, --no-interpolate, --no-normalize, --no-path-resolution, --profile filtering and env_file discarding. Restore the variadic wrapper (mirroring configOptions.ToModel) and route the five call sites through it.
Regression introduced by b80bb05 (LoadProject API migration).
Related issue
Fixes #13974
(not mandatory) A picture of a cute animal, if possible in relation to what you did
