Repository navigation
Conversation
Re-vendors specs/hosted-v1.yaml from ld main (a719c78de58). dolthub-v2.yaml is
unchanged there, so v2 is untouched.
GET /deployments/{owner}/{deployment}/metrics listDeploymentMetrics
GET /deployments/{owner}/{deployment}/metrics/{metric} getDeploymentMetric
plus Metric, MetricData, and MetricSeries. Deployment goes from 14 endpoints to
16 and models.md from 34 schemas to 37. Both are Deployment-tagged, so no new
page or nav entry.
The overview needed one correction beyond the two table rows. Its pagination
section lists the endpoints that return a list whole rather than paging it, and
the metrics catalogue is a third: it takes no page_token, since a deployment
collects on the order of ten metrics. The bidirectional case, log retrieval, is
unaffected.
Nothing in the long-running or errors sections changes — both metrics endpoints
are plain synchronous reads.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Three things the specs declared that the generated pages dropped. All are in the shared renderer, so both APIs pick them up. Array item types. A property whose items are a $ref rendered as bare `array`, with nothing to click: MetricData.series is a MetricSeries[], DeploymentConfig .settings a ConfigSetting[], and on v2 SqlQueryResult.columns a QueryColumn[]. The item type was being lost before the renderer saw it — models are deref'd on the way in, which flattens items.$ref into the anonymous object underneath. The raw schema is now threaded alongside the deref'd one, the same trick the parameter tables already used for enums, and a typeCell() helper renders both: $ref item types as links, primitive ones as `string[]`. The same helper picks up property $refs that had been flattened to their base type — v2's ErrorCode, OperationStatus, ImportFileType, BranchRef and friends, and hosted's CloudProvider and ClusterType — and JSON Schema union types, which 3.1 writes as a list: MetricSeries.values is (number | null)[], not `array`. Those pipes are escaped, since every one of these lands in a table cell. Object-level constraints. minProperties/maxProperties describe the object as a whole, so no per-field Required cell can express them. ExposeServiceRequest is min 1/max 1 — exactly one of remotesapi or mcp — but its table showed both as not required, which reads as "neither is needed". They now render as a line under the table, in request bodies and on the models page both. Extra request examples. Only one authored example per operation was rendered, and it was the one curl already shows. The second is usually the one carrying an idiom the first cannot: patchDeploymentConfig's null to clear an override, exposeDeploymentService's off switch. Those now follow the curl block. A discriminated union of inline objects keeps rendering as `object`, which is all v2's CreateBranchRequest.from can honestly be called; a union of $refs would render as linked alternatives. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Pick up the metrics endpoints from ld main
…nstraints-examples Carry item types, object constraints, and extra examples into the tables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.