Add FXDiscountCurve for FX-forward-implied discount curves#244
Closed
researchingadi wants to merge 4 commits into
Closed
Add FXDiscountCurve for FX-forward-implied discount curves#244researchingadi wants to merge 4 commits into
researchingadi wants to merge 4 commits into
Conversation
Implements FXDiscountCurve class for foreign discount curve calculations based on FX spot and forward rates.
domokane
approved these changes
Jul 12, 2026
Owner
|
OK. Had a quick look and it seems good. Merged. Thanks D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
FXDiscountCurve, a first-slice implementation for calibrating an implied foreign-currency discount curve from FX spot, FX forward quotes, and an existing domestic discount curve.This PR focuses only on short-tenor FX forwards and does not attempt to implement cross-currency basis swap calibration yet.
The curve follows FinancePy’s existing FX quote convention used by
FXForward: FX rates are quoted as domestic currency per unit of foreign currency. Given spotS, forwardF(T), and domestic discount factorDF_dom(T), the implied foreign discount factor is calculated as:DF_for(T) = F(T) / S * DF_dom(T)The resulting curve can reproduce the supplied FX forward quotes through:
F(T) = S * DF_for(T) / DF_dom(T)Related issue
Part of #102
Validation
FXDiscountCurveregression_tests/TestFinFXDiscountCurve.py