Conversation
Signed-off-by: Claudiu <claudiupintiuta@gmail.com>
alexmerlin
left a comment
alexmerlin
left a comment
There was a problem hiding this comment.
Please test these changes (especially the ones in src/Core) in Dotkernel Admin 7 as well.
| [ | ||
| 'source' => 'vendor/dotkernel/dot-mail/config/mail.global.php.dist', | ||
| 'destination' => 'config/autoload/mail.global.php', | ||
| 'destination' => 'config/autoload/mail.local.php', |
There was a problem hiding this comment.
We intentionally keep this file like this.
Reason:
As long as the file was not added manually into a project, we want to make sure that the latest version of vendor/dotkernel/dot-mail/config/mail.global.php.dist is being used.
| } | ||
|
|
||
| if (array_key_exists('identity', $data) && $data['identity'] !== null && ! $admin->hasIdentity()) { | ||
| if (array_key_exists('identity', $data) && $data['identity'] !== null) { |
There was a problem hiding this comment.
The reason we added && ! $admin->hasIdentity() was to make sure that an identity once set, will not be modified (as long as the saveAdmin() method is used).
This was added as an extra security step after the identity field was removed from src/Admin/src/InputFilter/UpdateAdminInputFilter.php.
| protected string $identity; | ||
|
|
||
| #[ORM\Column(name: 'password', type: 'string', length: 191)] | ||
| protected ?string $password = null; |
There was a problem hiding this comment.
Couldn't this be not nullable like the password field from src/Core/src/Admin/src/Entity/Admin.php?
| } | ||
|
|
||
| if (array_key_exists('identity', $data) && $data['identity'] !== null && ! $user->hasIdentity()) { | ||
| if (array_key_exists('identity', $data) && $data['identity'] !== null) { |
There was a problem hiding this comment.
Same note as with src/Admin/src/Service/AdminService.php.
2 participants
No description provided.