Skip to content

Use StructArmed on QA - #17

Merged
arhimede merged 1 commit into
dotkernel:1.0from
samsonasik:use-structarmed-on-qa
Oct 8, 2026
Merged

arhimede merged 1 commit into
dotkernel:1.0from
samsonasik:use-structarmed-on-qa

Conversation

@samsonasik

Copy link
Copy Markdown
Contributor

This PR to make use of StructArmed.

This PR start apply StructArmed with initialize using PSR4 and CODEQUALITY preset, and MustBeFinalRule to finalize class in test directory, and already fixes 4 violations.

applied with single command:

vendor/bin/structarmed analyze --fix

I also enable ruleset above so it show more ability of layering setup to define which layers each layer is allowed to depend on.

Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@samsonasik

Copy link
Copy Markdown
Contributor Author

@arhimede ready for review 👍

@arhimede
arhimede requested a review from alexmerlin October 7, 2026 16:31
@arhimede
arhimede merged commit fa19778 into dotkernel:1.0 Oct 8, 2026
21 of 23 checks passed
@arhimede

arhimede commented Oct 8, 2026

Copy link
Copy Markdown
Member

thanks @samsonasik

@samsonasik
samsonasik deleted the use-structarmed-on-qa branch October 8, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants