Document GSM SMS result errors - #457
Open
jonathanpeppers wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and
a lite review from Copilot
August 14, 2026 15:45
jonathanpeppers
enabled auto-merge (squash)
August 14, 2026 15:45
There was a problem hiding this comment.
Pull request overview
This PR replaces placeholder XML documentation in Android.Telephony.Gsm.SmsResultError with meaningful summaries for the four enum values, aligning the enum docs with the Android reference descriptions.
Changes:
- Replaced “To be added.” summaries with descriptions for
GenericFailure,RadioOff,NullPdu, andNoService. - Kept the existing remarks/licensing paragraphs intact while improving the member-level summaries.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
@dalexsoto review |
dalexsoto
requested changes
Aug 15, 2026
dalexsoto
left a comment
dalexsoto
left a comment
Member
There was a problem hiding this comment.
The PR currently has merge conflicts with the base branch. Please resolve the conflicts so the reviewed documentation changes can be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Android.Telephony.Gsm.SmsResultErrorvalues from the Android reference.Refs #231
Sources
Validation
docs/xml/Android.Telephony.Gsm/SmsResultError.xmlas XML.