Document LoggingPermission constructor - #460
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the API XML documentation for Java.Util.Logging.LoggingPermission to reflect the Java SE contract for the LoggingPermission(String, String) constructor, replacing “To be added.” placeholders with concrete parameter and summary text.
Changes:
- Documented the required
namevalue (control) for the constructor. - Documented the allowed
actionsvalues (nullor empty string). - Added a concise constructor
<summary>.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@dalexsoto review |
dalexsoto
left a comment
There was a problem hiding this comment.
docs/xml/Java.Util.Logging/LoggingPermission.xml: the constructor documents the accepted values but omits its enforced failure behavior. A null name throws Java.Lang.NullPointerException, while an empty/invalid name or invalid actions throw Java.Lang.IllegalArgumentException. Please document both exceptions.
Refs #251
Documents the Java SE
LoggingPermission(String, String)contract while leaving generated interop placeholders and unverified members out of scope.Sources
Validation
docs/xml/Java.Util.Logging/*.xmlfile as XML.git diff --checkand reviewed the focused namespace diff.