Document TemporalField unit properties - #498
Conversation
Refs #267 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR fills in missing XML documentation for key Java.Time.Temporal.ITemporalField unit-related members by translating the Java TemporalField contract docs into the generated .NET XML doc format.
Changes:
- Documented
BaseUnitsemantics and added a link to the corresponding Java reference. - Documented
IsDateBasedandIsTimeBasedcontract behavior (including derivation notes) with reference links. - Documented
RangeUnitsemantics with reference link and expanded remarks.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Refs #267 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
@dalexsoto review |
dalexsoto
left a comment
There was a problem hiding this comment.
docs/xml/Java.Time.Temporal/ITemporalField.xml: the IsDateBased and IsTimeBased remarks expose raw JavaDoc tokens (ChronoField#EPOCH_DAY EPOCH_DAY and ChronoField#NANO_OF_DAY NANO_OF_DAY) instead of managed API references. Please replace them with <see cref="P:Java.Time.Temporal.ChronoField.EpochDay" /> and <see cref="P:Java.Time.Temporal.ChronoField.NanoOfDay" />.
Refs #267 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
left a comment
There was a problem hiding this comment.
Addressed the requested correction: IsDateBased and IsTimeBased now use the managed ChronoField.EpochDay and ChronoField.NanoOfDay API references.
|
@dalexsoto review |
Summary
ITemporalField.BaseUnit,IsDateBased,IsTimeBased, andRangeUnitfrom JavaTemporalFieldcontract documentation.Refs #267
Sources
Validation
docs/xml/Java.Time.Temporal/ITemporalField.xmlas XML.To be added.placeholders remain in the scoped file.git diff --check, and noindex.xmlor namespace-index changes.